[BD-46] feat: added the "Edit this page" button #2604

PKulkoRaccoonGang · 2023-09-07T16:12:43Z

Description

added the "Edit this page" button,
added logic for this button.

Issue

Deploy Preview

Paragon site documentation

Merge Checklist

If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
Does your change adhere to the documented style conventions?
Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
Were your changes tested in the example app?
Is there adequate test coverage for your changes?
Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please add wittjeff and adamstankiewicz as reviewers on this PR.

Post-merge Checklist

Verify your changes were released to NPM at the expected version.
If you'd like, share your contribution in #show-and-tell.
🎉 🙌 Celebrate! Thanks for your contribution.

openedx-webhooks · 2023-09-07T16:12:48Z

Thanks for the pull request, @PKulkoRaccoonGang!

When this pull request is ready, tag your edX technical lead.

netlify · 2023-09-07T16:12:50Z

✅ Deploy Preview for paragon-openedx ready!

Built without sensitive environment variables

Name	Link
🔨 Latest commit	`7e5c7e1`
🔍 Latest deploy log	https://app.netlify.com/sites/paragon-openedx/deploys/65042cc94b593400080c8e1f
😎 Deploy Preview	https://deploy-preview-2604--paragon-openedx.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov · 2023-09-07T16:35:47Z

Codecov Report

Patch coverage has no change and project coverage change: +0.12% 🎉

Comparison is base (b39a6a4) 91.69% compared to head (7e5c7e1) 91.81%.
Report is 14 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2604      +/-   ##
==========================================
+ Coverage   91.69%   91.81%   +0.12%     
==========================================
  Files         235      235              
  Lines        4214     4217       +3     
  Branches     1021     1020       -1     
==========================================
+ Hits         3864     3872       +8     
+ Misses        346      341       -5     
  Partials        4        4

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

PKulkoRaccoonGang · 2023-09-11T14:20:19Z

www/src/templates/component-page-template.tsx

@@ -139,7 +142,10 @@ export default function PageTemplate({
        )}
        <div className="d-flex justify-content-between align-items-start">
          <h1 className="mb-4">{mdx.frontmatter.title}</h1>
-          <LeaveFeedback />
+          <Stack direction="horizontal" gap={3}>


I decided not to use ButtonGroup, since the buttons are not displayed very well visually

www/src/components/PageEditBtn/constants.js

adamstankiewicz · 2023-09-13T15:09:03Z

@PKulkoRaccoonGang It may also be a good idea to render the "Edit this page" CTA at the bottom of the page contents similar to how we show the "Leave feedback" in both spots. What do you think?

www/src/templates/component-page-template.tsx

www/src/components/PageEditBtn/index.tsx

www/src/components/PageEditBtn/constants.js

PKulkoRaccoonGang

@adamstankiewicz please take a look again. Currently, on component pages, we have a link to the "Edit this page" next to all the "Leave Feedback" links. We will add the “Edit this page” link in a separate pull request. Thank you!

www/src/components/PageEditBtn/constants.js

www/src/components/PageEditBtn/index.tsx

www/utils/createPages.js

openedx-webhooks · 2023-09-15T10:32:19Z

@PKulkoRaccoonGang 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

edx-semantic-release · 2023-09-20T09:17:27Z

🎉 This PR is included in version 21.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

edx-semantic-release · 2023-09-22T13:21:44Z

🎉 This PR is included in version 22.0.0-alpha.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

openedx-webhooks added the blended PR is managed through 2U's blended developmnt program label Sep 7, 2023

PKulkoRaccoonGang marked this pull request as draft September 7, 2023 16:12

PKulkoRaccoonGang mentioned this pull request Sep 7, 2023

"Edit this page" CTA on Paragon docs site #2533

Closed

feat: added Edit this page button

604acb7

PKulkoRaccoonGang force-pushed the Peter_Kulko/edit-page-btn branch from 1179c2a to 604acb7 Compare September 7, 2023 16:20

PKulkoRaccoonGang marked this pull request as ready for review September 7, 2023 16:21

PKulkoRaccoonGang requested review from viktorrusakov, monteri and adamstankiewicz September 7, 2023 19:58

bydawen approved these changes Sep 8, 2023

View reviewed changes

viktorrusakov linked an issue Sep 8, 2023 that may be closed by this pull request

"Edit this page" CTA on Paragon docs site #2533

Closed

PKulkoRaccoonGang marked this pull request as draft September 8, 2023 12:01

PKulkoRaccoonGang force-pushed the Peter_Kulko/edit-page-btn branch from cd7e49d to 47889b3 Compare September 11, 2023 10:48

PKulkoRaccoonGang marked this pull request as ready for review September 11, 2023 10:53

feat: added logic for Edit page button

241ebc7

PKulkoRaccoonGang force-pushed the Peter_Kulko/edit-page-btn branch from 47889b3 to 241ebc7 Compare September 11, 2023 11:03

PKulkoRaccoonGang commented Sep 11, 2023

View reviewed changes

viktorrusakov reviewed Sep 13, 2023

View reviewed changes

www/src/components/PageEditBtn/constants.js Outdated Show resolved Hide resolved

PKulkoRaccoonGang marked this pull request as draft September 13, 2023 13:15

PKulkoRaccoonGang force-pushed the Peter_Kulko/edit-page-btn branch 2 times, most recently from b2e528f to e5db3f6 Compare September 13, 2023 14:57

adamstankiewicz reviewed Sep 13, 2023

View reviewed changes

www/src/templates/component-page-template.tsx Outdated Show resolved Hide resolved

www/src/components/PageEditBtn/index.tsx Outdated Show resolved Hide resolved

www/src/components/PageEditBtn/constants.js Outdated Show resolved Hide resolved

PKulkoRaccoonGang force-pushed the Peter_Kulko/edit-page-btn branch from e5db3f6 to afe8acd Compare September 14, 2023 07:29

PKulkoRaccoonGang commented Sep 14, 2023

View reviewed changes

www/src/components/PageEditBtn/constants.js Outdated Show resolved Hide resolved

www/src/components/PageEditBtn/index.tsx Outdated Show resolved Hide resolved

PKulkoRaccoonGang force-pushed the Peter_Kulko/edit-page-btn branch from afe8acd to 66955d1 Compare September 14, 2023 07:49

PKulkoRaccoonGang marked this pull request as ready for review September 14, 2023 07:51

PKulkoRaccoonGang requested review from viktorrusakov, adamstankiewicz and bydawen September 14, 2023 08:19

refactor: refactorng after review

656dfd3

PKulkoRaccoonGang force-pushed the Peter_Kulko/edit-page-btn branch from 66955d1 to 656dfd3 Compare September 14, 2023 09:27

viktorrusakov reviewed Sep 14, 2023

View reviewed changes

www/utils/createPages.js Outdated Show resolved Hide resolved

refactor: moved link variable to file createPage.js

9242628

PKulkoRaccoonGang requested a review from viktorrusakov September 14, 2023 13:15

viktorrusakov mentioned this pull request Sep 15, 2023

Ensure both "Edit this page" and "Leave feedback" CTA on non-component pages #2625

Closed

refactor: refactoring tablet view

7e5c7e1

PKulkoRaccoonGang force-pushed the Peter_Kulko/edit-page-btn branch from e66588a to 7e5c7e1 Compare September 15, 2023 10:07

viktorrusakov approved these changes Sep 15, 2023

View reviewed changes

viktorrusakov merged commit b761187 into openedx:master Sep 15, 2023
9 checks passed

edx-semantic-release added the released label Sep 20, 2023

edx-semantic-release added the released on @alpha label Sep 22, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[BD-46] feat: added the "Edit this page" button #2604

[BD-46] feat: added the "Edit this page" button #2604

PKulkoRaccoonGang commented Sep 7, 2023 •

edited

Loading

openedx-webhooks commented Sep 7, 2023 •

edited

Loading

netlify bot commented Sep 7, 2023 •

edited

Loading

codecov bot commented Sep 7, 2023 •

edited

Loading

PKulkoRaccoonGang Sep 11, 2023

adamstankiewicz commented Sep 13, 2023

PKulkoRaccoonGang left a comment

openedx-webhooks commented Sep 15, 2023

edx-semantic-release commented Sep 20, 2023

edx-semantic-release commented Sep 22, 2023

[BD-46] feat: added the "Edit this page" button #2604

[BD-46] feat: added the "Edit this page" button #2604

Conversation

PKulkoRaccoonGang commented Sep 7, 2023 • edited Loading

Description

Deploy Preview

Merge Checklist

Post-merge Checklist

openedx-webhooks commented Sep 7, 2023 • edited Loading

netlify bot commented Sep 7, 2023 • edited Loading

✅ Deploy Preview for paragon-openedx ready!

codecov bot commented Sep 7, 2023 • edited Loading

Codecov Report

PKulkoRaccoonGang Sep 11, 2023

Choose a reason for hiding this comment

adamstankiewicz commented Sep 13, 2023

PKulkoRaccoonGang left a comment

Choose a reason for hiding this comment

openedx-webhooks commented Sep 15, 2023

edx-semantic-release commented Sep 20, 2023

edx-semantic-release commented Sep 22, 2023

PKulkoRaccoonGang commented Sep 7, 2023 •

edited

Loading

openedx-webhooks commented Sep 7, 2023 •

edited

Loading

netlify bot commented Sep 7, 2023 •

edited

Loading

codecov bot commented Sep 7, 2023 •

edited

Loading